[airflow] branch main updated: Fix number param html type in trigger template (#31946)

[potiuk]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new 2d44584f70 Fix number param html type in trigger template (#31946)
2d44584f70 is described below

commit 2d44584f7062113d2db2b8db92230911f8c19e3c
Author: Hussein Awala <huss...@awala.fr>
AuthorDate: Fri Jun 16 11:39:32 2023 +0200

    Fix number param html type in trigger template (#31946)
    
    Signed-off-by: Hussein Awala <huss...@awala.fr>
---
 airflow/www/templates/airflow/trigger.html | 5 +++--
 tests/models/test_param.py                 | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/airflow/www/templates/airflow/trigger.html 
b/airflow/www/templates/airflow/trigger.html
index d0b4eac2c5..c765f7537d 100644
--- a/airflow/www/templates/airflow/trigger.html
+++ b/airflow/www/templates/airflow/trigger.html
@@ -72,7 +72,7 @@
     {% elif "enum" in form_details.schema and form_details.schema.enum %}
       <select class="my_select2 form-control" name="element_{{ form_key }}" 
id="element_{{ form_key }}" data-placeholder="Select Value"
         onchange="updateJSONconf();"
-        {%- if "integer" in form_details.schema.type or "number" in 
form_details.schema.type %} valuetype="number"{% endif %}
+        {%- if "integer" in form_details.schema.type %} valuetype="number" {% 
elif "number" in form_details.schema.type %} valuetype="decimal" {%- endif %}
         {%- if not "null" in form_details.schema.type %} required=""{% endif 
%}>
         {% for option in form_details.schema.enum -%}
           <option value="{{ option }}"
@@ -116,7 +116,8 @@
         {{- form_details.value | tojson() -}}
       </textarea>
     {% elif form_details.schema and ("integer" in form_details.schema.type or 
"number" in form_details.schema.type) %}
-      <input class="form-control" name="element_{{ form_key }}" id="element_{{ 
form_key }}" valuetype="number" type="number"
+      <input class="form-control" name="element_{{ form_key }}" id="element_{{ 
form_key }}"
+             {% if "integer" in form_details.schema.type %} valuetype="number" 
type="number" {%else%} valuetype="decimal" type="decimal" {% endif %}
         value="{% if form_details.value %}{{ form_details.value }}{% endif %}"
         {%- if form_details.schema.minimum %} min="{{ 
form_details.schema.minimum }}"{% endif %}
         {%- if form_details.schema.maximum %} max="{{ 
form_details.schema.maximum }}"{% endif %}
diff --git a/tests/models/test_param.py b/tests/models/test_param.py
index 3688264b1a..64932213df 100644
--- a/tests/models/test_param.py
+++ b/tests/models/test_param.py
@@ -167,8 +167,8 @@ class TestParam:
         p = Param(42, type="number")
         assert p.resolve() == 42
 
-        p = Param(1.0, type="number")
-        assert p.resolve() == 1.0
+        p = Param(1.2, type="number")
+        assert p.resolve() == 1.2
 
         with pytest.raises(ParamValidationError):
             p = Param("42", type="number")