ashb commented on issue #5615: [AIRFLOW-5035] Remove multiprocessing.Manager 
in-favour of Pipes
URL: https://github.com/apache/airflow/pull/5615#issuecomment-515916747
 
 
   @KevinYang21 
   
   `reap_process_group` is _almost_ what we want, except for the fact that the 
manager doesn't create a new process group (`os.getpgid(self._process.pid)` 
would return the main `airflow scheduler process`!) - I'll look about making 
the manager a new process group as reap_process_group is closer to what we want 
and and quite similar to the code already in `DagFileProcessorAgent.end`.
   
   On replacing mp.Manager inside the executors too: yes good idea. I'll take a 
look and see how much work it is. I may punt it to another PR as this is 
currently a blocker on the next RC of 1.10.4

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to