hussein-awala commented on PR #31833: URL: https://github.com/apache/airflow/pull/31833#issuecomment-1595785593
> Should we just use urljoin instead of raw string formatting to handle the slashes instead? it's possible for the changes in `airflow/models/taskinstance.py` but not for the one in `airflow/www/extensions/init_wsgi_middlewares.py` since we don't join it to something else, but we provide it as an argument to a 3rd party lib. > If we want to eliminate the possibility, I’d prefer an startup-time check to ensure the config is set without a trailing slash. If a trailing slash is found, Airflow can refuse to launch and prompt the user to correct the value. I will try this one, and I don't think it's a braking change since it doesn't work with a trailing slash anyway -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
