hussein-awala commented on PR #31985: URL: https://github.com/apache/airflow/pull/31985#issuecomment-1596050743
> I am not sure how recovery is implemented in case the event is emitted, but the processing does not manage to complete, but I assume this can only happen in case Triggerer crashes, and in this case the Trigger will be re-started as the database operation saving the state of the triggerer will not happen, so this case should also be handled properly and there is generally no need to continue the loop anyway. @potiuk I agree. I have also opened and tested #31987, which can effectively prevent the problem on the triggerer side. However, even if we merge that PR, we still need the `return` statements added in current PR to avoid executing unnecessary checks, such as the call to the kube cluster for state verification in `KubernetesPodTrigger`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
