cablespaghetti opened a new issue, #32003:
URL: https://github.com/apache/airflow/issues/32003

   ### Official Helm Chart version
   
   1.9.0 (latest released)
   
   ### Apache Airflow version
   
   2.6.2
   
   ### Kubernetes Version
   
   1.25.9
   
   ### Helm Chart configuration
   
   All relevant settings for this issue are default. My database was on v2.5 
and I was trying to upgrade to v2.6 but I'm not certain if that had an impact.
   
   ### Docker Image customizations
   
   _No response_
   
   ### What happened
   
   The migrations job has is set to run `post-install,post-upgrade` but because 
the rest of the Pods have init containers to `wait-for-migrations` the 
post-install/upgrade hooks never run. This results in the chart never finishing 
deploying.
   
   
https://github.com/apache/airflow/blob/0560881f0eaef9c583b11e937bf1f79d13e5ac7c/chart/templates/jobs/migrate-database-job.yaml#LL45C1-L45C77
   
   I've worked around this by tweaking the annotations:
   ```
       migrateDatabaseJob:
         useHelmHooks: false
         annotations:
           helm.sh/hook: "pre-install,pre-upgrade"
           helm.sh/hook-weight: "1"
   ```
   
   ### What you think should happen instead
   
   The migrations should be a pre-upgrade/pre-install hook to ensure they have 
run before the rest of the Pods come up.
   
   ### How to reproduce
   
   Try upgrading from 2.5 to 2.6 and see the pods wait-for-migrations forever 
and migrations never running. This might impact fresh installs, I am not 
certain yet.
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to