syedahsn commented on code in PR #30463: URL: https://github.com/apache/airflow/pull/30463#discussion_r1234567369
########## airflow/providers/amazon/aws/utils/waiter_with_logging.py: ########## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import logging +import time + +from botocore.exceptions import WaiterError + +from airflow.exceptions import AirflowException + + +def wait( + waiter, + waiter_delay, + max_attempts, + state_args, + failure_message, + status_message, +): + log = logging.getLogger(__name__) + attempt = 0 + while attempt < max_attempts: + attempt += 1 + try: + waiter.wait( Review Comment: yea, we need to have 2 separate methods unfortunately. Its still better than not using boto waiters at all (because we would then have to write hook code that would make the actual API calls), but we lose the simplicity of having a single shared wait function for asycn and sync cases :disappointed: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
