eladkal commented on code in PR #31787:
URL: https://github.com/apache/airflow/pull/31787#discussion_r1234913952
##########
airflow/utils/db.py:
##########
@@ -477,6 +477,19 @@ def create_default_connections(session: Session =
NEW_SESSION):
),
session,
)
+ merge_conn(
+ Connection(
+ conn_id="adb_spark_default",
+ conn_type="adb_spark",
Review Comment:
Where is `adb` coming from? (I understand it's for AnalyticDB but is it
something you came up with?
I didn't find `adb` to officially used in Alibaba cloud docs.
On another front, cc also @ephraimbuddy @pierrejeambrun would you prefer to
have this change in a separated PR? This file change is a core change that
needs to be released with Airflow core not with providers. This also means that
the connection will be available only to Airflow 2.7.0+
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
