uranusjr commented on code in PR #32016:
URL: https://github.com/apache/airflow/pull/32016#discussion_r1235016504
##########
airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -216,7 +216,16 @@ def _get_conn_params(self) -> dict[str, str | None]:
"Please remove one."
)
elif private_key_file:
- private_key_pem = Path(private_key_file).read_bytes()
+ private_key_file_path = Path(private_key_file)
+ if not private_key_file_path.is_file() or
private_key_file_path.stat().st_size == 0:
+ raise AirflowException(
+ "The private_key_file path points to an empty or invalid
file."
+ )
Review Comment:
Still does not explain the extra stat check though? `is_file` only returns
true for regular files.
Also this can benefit from a better exception class than AirflowException. A
ValueError, OSError, or PermissionError would be more appropriate IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
