JDarDagran commented on code in PR #31609:
URL: https://github.com/apache/airflow/pull/31609#discussion_r1235157600


##########
airflow/providers/mysql/hooks/mysql.py:
##########
@@ -298,3 +298,24 @@ def bulk_load_custom(
         cursor.close()
         conn.commit()
         conn.close()  # type: ignore[misc]
+
+    def get_database_info(self, connection):
+        from airflow.providers.openlineage.sqlparser import DatabaseInfo
+
+        return DatabaseInfo(
+            scheme=self.get_database_dialect(connection),
+            authority=self._get_authority(connection),
+            information_schema_columns=[
+                "table_schema",
+                "table_name",
+                "column_name",
+                "ordinal_position",
+                "column_type",
+            ],
+            normalize_name_method=lambda name: name.upper(),

Review Comment:
   tbh case sensitivity across different SQL databases is a bit problematic but 
so far we assumed so for MySQL in OpenLineage and I would not want to break it 
in this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to