jedcunningham commented on code in PR #31890:
URL: https://github.com/apache/airflow/pull/31890#discussion_r1235267947
##########
airflow/utils/sqlalchemy.py:
##########
@@ -429,6 +430,20 @@ def with_row_locks(query, session: Session, **kwargs):
return query
[email protected]
+def lock_rows(query: Query, session: Session) -> Generator[list[Any], None,
None]:
+ """Lock database rows during the context manager block.
+
+ This is a convenient method for ``with_row_locks`` when we don't need the
+ locked rows.
Review Comment:
Can we maybe change up this docstring a bit? Saying we don't "need" the
locked rows then yielding them out doesn't seem consistent. (or the other way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
