syedahsn commented on code in PR #32029:
URL: https://github.com/apache/airflow/pull/32029#discussion_r1236429130
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -555,6 +559,22 @@ def execute(self, context: Context) -> str | None:
self.client_request_token,
self.tags,
)
+ if self.deferrable:
+ timeout = (
+ timedelta(seconds=self.max_polling_attempts *
self.poll_interval + 60)
Review Comment:
Honestly, I'm thinking that with
https://github.com/apache/airflow/pull/31757 closed (by @Lee-W :smile: ), that
60 seconds is no longer necessary. I initially added it because the Trigger
would not log an error when timing out, so I added 60 seconds so the Trigger
had some time to exit gracefully.
I haven't tested the new timeout feature myself, but if it works as
intended, then I think we can leave the 60 seconds off. What do you guys think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
