Aakcht commented on code in PR #31865:
URL: https://github.com/apache/airflow/pull/31865#discussion_r1238213959
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -89,7 +88,7 @@ spec:
- name: statsd
image: {{ template "statsd_image" . }}
imagePullPolicy: {{ .Values.images.statsd.pullPolicy }}
- securityContext: {{ $containerSecurityContext | nindent 12 }}
+ securityContext: {{- toYaml
.Values.statsd.securityContexts.container | nindent 12 }}
Review Comment:
Also, if by backcompat you mean that `stastd.securityContext` shoud end up
in statsd container security context - I disagree, in the current dev version
`stastd.securityContext` is not passed to statsd container security context,
see
https://github.com/apache/airflow/blob/main/chart/templates/_helpers.yaml#L842
and
https://github.com/apache/airflow/blob/main/chart/templates/statsd/statsd-deployment.yaml#L30
. And as I said before, in previous releases statsd container security context
wasn't even present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
