tomrutter opened a new pull request, #32092: URL: https://github.com/apache/airflow/pull/32092
Updates to triggerer job to improve robustness. Context: Triggerer runs two threads, one synchronous and one asynchronous. The synchronous thread handles db updates, and the asynchronous thread handles custom trigger code. The heartbeat update for the job happens in the synchronous thread. Details (two updates): 1. Added a check for missing associated task_instance when adding a trigger. This prevents a crash in the triggerer async thread when updating with partially updated data. The trigger concerned is ignored, and will later deleted by Trigger.clean_unused() in the synchronous thread. 2. Added a check that the async thread is still running before updating triggerer heartbeat. This results in the triggerer being reported as unhealthy (and subsequently restarted) when the async thread crashes. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #32091 How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
