utkarsharma2 commented on code in PR #31887:
URL: https://github.com/apache/airflow/pull/31887#discussion_r1239931336
##########
tests/dag_processing/test_processor.py:
##########
@@ -124,6 +124,13 @@ def test_dag_file_processor_sla_miss_callback(self,
mock_get_dagbag, create_dumm
session.merge(TaskInstance(task=task, execution_date=test_start_date,
state="success"))
session.merge(SlaMiss(task_id="dummy", dag_id="test_sla_miss",
execution_date=test_start_date))
+ session.commit()
+
+ slas_miss_objects: list[SlaMiss] = (
+ session.query(SlaMiss)
+ .filter(SlaMiss.notification_sent == False, SlaMiss.dag_id ==
dag.dag_id) # noqa
+ .all()
+ )
Review Comment:
Was done to make sure the arguments are handled correctly, but now that we
are not touching `dag_processor` this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
