tatiana commented on code in PR #31398:
URL: https://github.com/apache/airflow/pull/31398#discussion_r1242196460
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -515,3 +516,55 @@ def test_connection(self):
message = str(e)
return status, message
+
+ def get_database_info_for_openlineage(self, connection):
+ """
+ Should return database specific information needed
+ to generate and parse lineage metadata.
+ This includes information helpful for constructing information schema
query
+ and creating correct namespace.
+
+ :param connection: Airflow connection to reduce calls of
`get_connection` method
+ :return: A
:class:`airflow.providers.openlineage.sqlparser.DatabaseInfo` instance.
+ """
+
+ def get_database_dialect(self, connection) -> str:
Review Comment:
What do you think if suffixing all open lineage-specific methods with
`openlineage`?
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -515,3 +516,55 @@ def test_connection(self):
message = str(e)
return status, message
+
+ def get_database_info_for_openlineage(self, connection):
+ """
+ Should return database specific information needed
+ to generate and parse lineage metadata.
+ This includes information helpful for constructing information schema
query
+ and creating correct namespace.
+
+ :param connection: Airflow connection to reduce calls of
`get_connection` method
+ :return: A
:class:`airflow.providers.openlineage.sqlparser.DatabaseInfo` instance.
+ """
+
+ def get_database_dialect(self, connection) -> str:
+ """Method used for SQL parsing.
+
+ For a list of supported dialects check:
https://openlineage.io/docs/development/sql#sql-dialects
+ """
+ return "generic"
+
+ def get_default_schema(self):
Review Comment:
What do you think if suffixing all open lineage-specific methods with
`openlineage`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
