uranusjr commented on code in PR #31663:
URL: https://github.com/apache/airflow/pull/31663#discussion_r1243156752
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -398,14 +417,78 @@ def consume_logs(
)
time.sleep(1)
+ def fetch_requested_container_logs(
Review Comment:
It seems this entire function can be transformed into a generator function
instead and use `yield` to get rid of all the `append` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
