potiuk commented on PR #32183: URL: https://github.com/apache/airflow/pull/32183#issuecomment-1609679826
> I like the new layout a lot. > > I have few questions/suggestions though (The image of ours is awfully out-dated and I would like to use the opportunity to fix that): > > 1. Can you please add Triggerer there? It's been missing for quite some time > 2. Can you please also separate DAG file processor from scheduler "optionally" to show that it can run as an independent component? IT would then access both DB and DAG files, while scheduler would not run DAG files. > 3. Web server should not need access to DAG files (In modern Airflow the main DAG file source code is stored in the metadata DB and this is where Webserver reads it from) > 4. Is it possible to get sources of the image as well and (that might be the next step) a way to generate it automatically ? > > Not sure how you generated that image - but one of the main reasons it is out-dated is that we always need to re-do the whole image from scratch every time there is a smallest change (and you see what it leads to). So we discussed that we need to get a way to generate the image automatically - #21071 - either rendering it by GitHub (mermaid) or maybe some other way. If you have some way to generate such an image from a text description that would be ideal, second best is to habe some kind of vector diagram sources committed that can be opened and edited using some free-open-source (ideally) or free service (less ideal) tool (+ short readme instructions on what program to use and how. > > Is it too much to ask as part of the PR ? 5. Also one more thing. We are discussing the new Security Model description in this PR: https://github.com/apache/airflow/pull/32098 . It would be great if this diagram correctly reflects the security model where we have different kinds of users: https://github.com/apache/airflow/pull/32098/files#diff-557b4d5c3afac490c77cf2d29f8ec737961c7182dad6c9da24d44f6034bce6a7R66 Basically - we have DAG Author who writes DAGs, Deployment Manager who can edit configuration and Authenticated UI users who can access UI and API. Including these three personas in the new diagram is something I think is necessary to complete the picture and have a visual representation of - from the proposed diagram it seem that this is one "persona". While this might be the case in simple installations (where all the three personnas are the same person) in general case those are different users having different permissions and different capabilities. The in-progress security model already explains it but having it also reflected in the updated diagram would make it complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
