JDarDagran commented on PR #31398:
URL: https://github.com/apache/airflow/pull/31398#issuecomment-1611112686
> Some general coding style comments I find confusing:
>
> 1. Why `dict(key=value, ...)` instead of `{}`?
> 2. There are local imports (sqlparse?) that seemingly can be done globally.
> 3. Reasoning is needed for the `# type: ignore` mypy comments.
> 4. Please reformat most of the docstrings to have a short, single sentence
summary, a blank line, and longer descriptions in a separate paragraph.
@uranusjr
1. Changed to `{}`.
2. Moved `import sqlparse` to global. Did not find anything else.
3. I've fixed all typing issues and got rid of `# type: ignore`.
4. Reformatted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
