o-nikolas commented on code in PR #32217: URL: https://github.com/apache/airflow/pull/32217#discussion_r1245674247
########## airflow/auth/managers/fab/__init__.py: ########## Review Comment: You could put the FabAuthManager class here so that you could import it like `airflow.auth.managers.fab.FabAuthManager` instead of `airflow.auth.managers.fab.fab_auth_manager.FabAuthManager` ########## airflow/configuration.py: ########## @@ -1808,4 +1827,5 @@ def __getattr__(name): conf = initialize_config() secrets_backend_list = initialize_secrets_backends() +auth_manager = initialize_auth_manager() Review Comment: This module is already hugely dependent on a lot of other modules and very often creates import cycles. Does this have to be initialized here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
