aagateuip commented on code in PR #32113:
URL: https://github.com/apache/airflow/pull/32113#discussion_r1245935423


##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -562,11 +577,38 @@ def extract_xcom(self, pod: V1Pod) -> str:
                 resp,
                 f"if [ -s {PodDefaults.XCOM_MOUNT_PATH}/return.json ]; then 
cat {PodDefaults.XCOM_MOUNT_PATH}/return.json; else echo 
__airflow_xcom_result_empty__; fi",  # noqa
             )
-            self._exec_pod_command(resp, "kill -s SIGINT 1")
+            if isinstance(result, str) and result.rstrip() != 
"__airflow_xcom_result_empty__":

Review Comment:
   Static check was failing without checking for string. But made change you 
suggested - lets see if it passes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to