dstandish commented on PR #32249: URL: https://github.com/apache/airflow/pull/32249#issuecomment-1612431248
hi, welcome @dirrao from looking at the code alone, it's hard to understand what the effect of the change is and why it has the effect. it's also important to be sure that it doesn't break anything e.g. how do we know pods will still be deleted in "legitimate" circumstances. can you add some explanation re how your change works? Additionally I see that no tests are added, though one updated. It seems likely that we are missing coverage for the scenario that you are trying to address. Additionally can you make sure that we have coverage for the scenario we wish not to break, i.e. the scenario in which perhaps it was working properly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
