eladkal commented on code in PR #32253:
URL: https://github.com/apache/airflow/pull/32253#discussion_r1246163141
##########
airflow/providers/databricks/operators/databricks_sql.py:
##########
@@ -70,14 +70,11 @@ class DatabricksSqlOperator(SQLExecuteQueryOperator):
:param csv_params: parameters that will be passed to the
``csv.DictWriter`` class used to write CSV data.
"""
- template_fields: Sequence[str] = (
- "sql",
- "_output_path",
- "schema",
- "catalog",
- "http_headers",
- "databricks_conn_id",
+ template_fields: Sequence[str] = tuple(
+ {"_output_path", "schema", "catalog", "http_headers",
"databricks_conn_id"}
Review Comment:
@alexott I find it really confusing that this operator has
`databricks_conn_id` from this class and also `conn_id` from parent class.
Something worth addressing in a followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
