uranusjr commented on code in PR #32218:
URL: https://github.com/apache/airflow/pull/32218#discussion_r1246417500
##########
tests/utils/test_singleton.py:
##########
@@ -23,9 +23,19 @@ class A(metaclass=Singleton):
pass
+class Counter(metaclass=Singleton):
Review Comment:
Probably needs a docstring or some better named class/variable names, I
imagine I’d have difficulties understanding what this class (and the test)
actually does if I read this code a couple of months later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]