Lee-W opened a new pull request, #32261:
URL: https://github.com/apache/airflow/pull/32261

   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ## What's the issue
   In airflow/airflow/api_connexion/endpoints/config_endpoint.py,  
`conf.getboolean("webserver", "expose_config")` only handle the boolean cases 
without handling "non-sensitive-only" which is a valid value according to 
[doc](https://airflow.apache.org/docs/apache-airflow/2.6.2/configurations-ref.html#expose-config)
   
   
   
https://github.com/apache/airflow/blob/f2e2125b070794b6a66fb3e2840ca14d07054cf2/airflow/api_connexion/endpoints/config_endpoint.py#L79,
 
https://github.com/apache/airflow/blob/f2e2125b070794b6a66fb3e2840ca14d07054cf2/airflow/api_connexion/endpoints/config_endpoint.py#L108
   
   
   ## How to reproduce 
   
   1. add the following value to `files/airflow-breeze-config/variables.env`
   
   ```
   AIRFLOW__WEBSERVER__EXPOSE_CONFIG=NON-SENSITIVE-ONLY
   AIRFLOW__API__AUTH_BACKENDS=airflow.api.auth.backend.default
   ```
   
   2. `breeze --python 3.9 --backend sqlite start-airflow`
   3. log in through Airflow UI
   4. Go to `http://127.0.0.1:28080/api/v1/config` and 
`http://127.0.0.1:28080/api/v1/config/section/database/option/sql_alchemy_conn`.
 both of them fail
   
   ## What's changed
   
   "non-sensitive-only" is handled in the code section mentioned in **## What's 
the issue**. Sensitive data will be replace as `< hidden >` like how it's 
implemented elsewhere
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to