manuel-lang commented on PR #32257: URL: https://github.com/apache/airflow/pull/32257#issuecomment-1613510911
> I would be rather against that at least not until someone works on upgrading the mssql suport for ARM image. > > There are (were) various problems with MSSQL mostly related to not supporting all architectures and operating system - including the fact that for now we are excluding mssql-client from installation on ARM architecture https://github.com/apache/airflow/blob/main/scripts/docker/install_pipx_tools.sh#L27 > > This means that users of the ARM image will not be able to connect to the mssql database using client. Possibly this issu has been solved - but fixing it should be the first step. > > Do you have access to ARM/M1 to test it and make a fix to not exclude mssql-cli from installation and make such PR @manuel-lang ? Should be as easy as running `breeze ci-image build` after making the change to exclude ARM and running pre-commit (to regenerate scripts embedded in Dockerfiles). As written by @potiuk, mssql-cli is not supported on ARM devices. I just checked it and it still is not. So based on the explanation, I'll just close this MR. However, [mssql-cli](https://github.com/dbcli/mssql-cli) now is (or will be) deprecated in favor of [gosql-cmd](https://learn.microsoft.com/de-de/sql/tools/sqlcmd/go-sqlcmd-utility?view=sql-server-ver16&tabs=windows). Copy of their deprecation notice: > DEPRECATION NOTICE mssql-cli is on the path to deprecation, and will be fully replaced by the new [go-sqlcmd](https://learn.microsoft.com/sql/tools/sqlcmd/go-sqlcmd-utility) utility once it becomes generally available. We are actively in development for the new sqlcmd, and would love to hear feedback on it [here](https://github.com/microsoft/go-sqlcmd/issues)! Maybe this is something to be aware of. Also sqlcmd works just fine on ARM architectures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
