juhai commented on code in PR #32278:
URL: https://github.com/apache/airflow/pull/32278#discussion_r1247615857
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -158,6 +158,8 @@ class KubernetesPodOperator(BaseOperator):
suffix if random_name_suffix is True) to generate a pod id (DNS-1123
subdomain,
containing only [a-z0-9.-]).
:param random_name_suffix: if True, will generate a random suffix.
+ :param job_id_as_suffix: if True, will add ti.job_id to the pod name.
random_name_suffix, if set to True
+ takes precedence over this parameter.
Review Comment:
Hi, I agree with your proposal to change the suffixing logic instead. I
don't know how the deprecation process would work for this, though.
This is using `ti.job_id` which I think is assigned by airflow, `task_id` is
separate and can be supplied in `KubernetesPodOperator`. We shouldn't use that
for the reason you state. I have not seen a way to modify the `job_id`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
