eladkal commented on PR #32259: URL: https://github.com/apache/airflow/pull/32259#issuecomment-1615867774
> @eladkal @vincbeck can you refer me to the tests that should be updated? Should I add some new once, and if so -- where? Sure. The hook is tested with string payload https://github.com/apache/airflow/blob/9d9b15989a02042a9041ff86bc7e304bb06caa15/tests/providers/amazon/aws/hooks/test_lambda_function.py#L28 you should add a new test / extend existed test to also test byte payload. I think in this case probably just making the test accept multiple inputs (strings and bytes) using `@pytest.mark.parametrize `will do the trick (you can find many examples for this in the source code) The same goes for testing the operator class https://github.com/apache/airflow/blob/38b901ec3f07e6e65880b11cc432fb8ad6243629/tests/providers/amazon/aws/operators/test_lambda_function.py#L77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
