This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-6-test in repository https://gitbox.apache.org/repos/asf/airflow.git
commit cc5c4ffe59e4f797c1833c02f8516dcd1fc4441a Author: Jarek Potiuk <[email protected]> AuthorDate: Fri Jun 23 10:20:49 2023 +0200 Remove casting of forward_credentials for shell and start-airflow breeze (#32087) The forward-credentials flag was supposed to be disabled when you run start-airflow and shell commands. However the flag boolean value has been casted to str so False became "False" and forward-credentials for these two commaands have been enabled by default no matter if the flag was used. In effect for example .docker configuration and credentials have been forwarded to inside the docker container via `.docker` folder mapped, and in case you had some credentials helper or plugin configured there, it was also set for docker configuration. Using the boolean value fixes the problem. Now you shoudl specify the --forward-credentials flag explicitly to forward credentials. (cherry picked from commit 3ead4aa610b3381c8b3f4eecc2be34bb8c9ba16b) --- dev/breeze/src/airflow_breeze/commands/developer_commands.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev/breeze/src/airflow_breeze/commands/developer_commands.py b/dev/breeze/src/airflow_breeze/commands/developer_commands.py index 59428b42da..66907aa3f6 100644 --- a/dev/breeze/src/airflow_breeze/commands/developer_commands.py +++ b/dev/breeze/src/airflow_breeze/commands/developer_commands.py @@ -180,7 +180,7 @@ def shell( postgres_version=postgres_version, mysql_version=mysql_version, mssql_version=mssql_version, - forward_credentials=str(forward_credentials), + forward_credentials=forward_credentials, mount_sources=mount_sources, use_airflow_version=use_airflow_version, airflow_extras=airflow_extras, @@ -287,7 +287,7 @@ def start_airflow( load_example_dags=load_example_dags, mysql_version=mysql_version, mssql_version=mssql_version, - forward_credentials=str(forward_credentials), + forward_credentials=forward_credentials, mount_sources=mount_sources, use_airflow_version=use_airflow_version, airflow_extras=airflow_extras,
