potiuk commented on PR #31398: URL: https://github.com/apache/airflow/pull/31398#issuecomment-1616564161
I think it's perfectly fine. 'openlineage' extra is optional, and I thinl (looking at the code) all the openlineage imports are under "TYPE_CHECKING" flag. Surely the openlineage package is not yet published, but at most it means that no-one will be able to use "openlineage" extra YET. Not until openlineage provider is released. But a good thing is that once it is released, it will work as expected witht this common.sql package that is going to be released now - in other words, if in the future openlineage provider is released, there will be no need to release common.sql. I see fundamentally no problem with releasing common.sql with that code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
