pierrejeambrun commented on code in PR #32303: URL: https://github.com/apache/airflow/pull/32303#discussion_r1249588580
########## airflow/cli/commands/provider_command.py: ########## @@ -17,7 +17,7 @@ """Providers sub-commands.""" from __future__ import annotations -import re +import re2 as re Review Comment: Fallback is explicit in `pyre2` (we are not using it), but I didn't find any mention of it in python `google-re2` bindings. I tried a few unsupported regexp and it threw errors straight away. I believe there is no fallback, this was discussed on the issue. Did you find example or doc regarding fallback for `google-re2` ? re2 solves the ReDos problem with linear time regexp engine. I don't have newer arguments than what has already been discussed in the github issue. (backtracking problem, pyre2 vs google-re2, fallback etc.). As it is not yet released with a patch for this I purposely didn't give too many details here. If we prefer a different approach, just let me know I can close this in favor of other suggestions. If needed can we follow up on the `airflow-s` issue, or security mailing list ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
