amoghrajesh commented on code in PR #31868:
URL: https://github.com/apache/airflow/pull/31868#discussion_r1250962465
##########
tests/charts/airflow_core/test_worker.py:
##########
@@ -373,6 +373,17 @@ def test_should_create_default_affinity(self):
docs[0],
)
+ def test_runtime_class_name_values_are_configurable(self):
+ docs = render_chart(
+ values={
+ "workers": {"runtimeClassName": "nvidia"},
+ },
+ show_only=["templates/workers/worker-deployment.yaml"],
+ )
+
+ runtimeclassname =
jmespath.search("spec.template.spec.runtimeClassName", docs[0])
+ assert runtimeclassname == "nvidia"
Review Comment:
You can just do an `assert
jmespath.search("spec.template.spec.runtimeClassName", docs[0]) == "nvidia"`
here
##########
chart/values.yaml:
##########
@@ -2056,36 +2062,36 @@ config:
# `run_duration` included for Airflow 1.10 backward compatibility; removed
in 2.0.
run_duration: 41460
elasticsearch:
- json_format: 'True'
+ json_format: "True"
log_id_template: "{dag_id}_{task_id}_{execution_date}_{try_number}"
elasticsearch_configs:
max_retries: 3
timeout: 30
- retry_timeout: 'True'
+ retry_timeout: "True"
kerberos:
- keytab: '{{ .Values.kerberos.keytabPath }}'
- reinit_frequency: '{{ .Values.kerberos.reinitFrequency }}'
- principal: '{{ .Values.kerberos.principal }}'
- ccache: '{{ .Values.kerberos.ccacheMountPath }}/{{
.Values.kerberos.ccacheFileName }}'
+ keytab: "{{ .Values.kerberos.keytabPath }}"
+ reinit_frequency: "{{ .Values.kerberos.reinitFrequency }}"
+ principal: "{{ .Values.kerberos.principal }}"
+ ccache: "{{ .Values.kerberos.ccacheMountPath }}/{{
.Values.kerberos.ccacheFileName }}"
celery_kubernetes_executor:
- kubernetes_queue: 'kubernetes'
+ kubernetes_queue: "kubernetes"
Review Comment:
Were all these changes from single quotes to double quotes done by mistake?
Looks to me as if the editor did it.
##########
chart/values.yaml:
##########
@@ -1950,7 +1951,12 @@ cleanup:
# Command to use when running the cleanup cronjob (templated).
command: ~
# Args to use when running the cleanup cronjob (templated).
- args: ["bash", "-c", "exec airflow kubernetes cleanup-pods --namespace={{
.Release.Namespace }}"]
+ args:
+ [
+ "bash",
+ "-c",
+ "exec airflow kubernetes cleanup-pods --namespace={{ .Release.Namespace
}}",
+ ]
Review Comment:
Same comment as below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
