bhagany commented on issue #32106: URL: https://github.com/apache/airflow/issues/32106#issuecomment-1618909358
I'm still on vacation, but popping in here to add my 2 cents regarding your PR @avinashpandeshwar -- I don't think these PR's are mutually compatible, with regard to how they treat @Yaro1's changes. I see that your PR currently keeps the default to the storage project if it is not provided, but I would make a case that this is probably more confusing than it's worth. The storage project and the compute project are different things, and conflating them in these operators only furthers misunderstandings that exist about this. This is all only my opinion, of course. I agree with @hussein-awala's comment on #32095, linked above, and would prefer the approach taken in #32143, which keeps the `project_id` parameter, and falls back to the hook's `project_id`. This behavior is the most consistent with other operators, and avoids the storage/compute project confusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
