potiuk commented on PR #32361:
URL: https://github.com/apache/airflow/pull/32361#issuecomment-1621285339
> > I am not 100% sure if this is right in all cases - maybe other can
confirm, but regardless, this changes the output of the public API, which
someone might rely on (even if it was wrong). If we agree to change it (and
classify it as bugfix, not a breaking change), then at the very least, we
should have a significant newsfragment describing the change.
>
> From public API I understand the endpoint (correct me if I am wrong here)
- `api/v1/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/{task_id}` and the
value of `try_number` here is already coming from `_try_number`. Do you mean
the same when you say public API?
>
> The API I have changed returns the HTML page. I think its safe to fix this
without any impact to users. It in fact syncs with the public API after this
fix.
Ah right stupid me (note to self: read more carefully) :). :facepalm: ,
sorry.
Indeed - I have looked mostly at the description, not the code when I made
the assessment.
The ones in the public API come from the table - which might indeed be
different from the TaskInstance try_num property as you mentioned in the linked
issue.
I wonder if there is a case it might be wrong (I don't think so- looks like
it will always be "right" looking at the property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
