ashb commented on a change in pull request #5281: WIP: [AIRFLOW-4506] Make
GIT_SYNC_DEPTH and GIT_SYNC_REV configurable
URL: https://github.com/apache/airflow/pull/5281#discussion_r308687200
##########
File path: airflow/kubernetes/worker_configuration.py
##########
@@ -64,10 +64,13 @@ def _get_init_containers(self):
'value': self.kube_config.git_sync_dest
}, {
'name': 'GIT_SYNC_DEPTH',
- 'value': '1'
+ 'value': self.kube_config.git_sync_depth if
self.kube_config.git_sync_depth else '1'
Review comment:
Don't' put the default in code, just put the default in the config file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
