Adaverse commented on code in PR #32368:
URL: https://github.com/apache/airflow/pull/32368#discussion_r1252938609
##########
tests/system/providers/google/cloud/automl/example_automl_nl_text_classification.py:
##########
@@ -35,17 +35,14 @@
AutoMLTrainModelOperator,
)
-GCP_PROJECT_ID = os.environ.get("GCP_PROJECT_ID", "your-project-id")
-GCP_AUTOML_LOCATION = os.environ.get("GCP_AUTOML_LOCATION", "us-central1")
-GCP_AUTOML_TEXT_CLS_BUCKET = os.environ.get("GCP_AUTOML_TEXT_CLS_BUCKET",
"gs://INVALID BUCKET NAME")
-
-# Example values
-DATASET_ID = ""
+ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
+DAG_ID = "example_automl_classification"
+GCP_PROJECT_ID = os.environ.get("SYSTEM_TESTS_GCP_PROJECT", "default")
+GCP_AUTOML_LOCATION = "us-central1"
Review Comment:
Should we hardcode these values? Shouldn't it be fetched from env var?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
