xuganyu96 opened a new pull request, #32385:
URL: https://github.com/apache/airflow/pull/32385
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #32287, #28777, #32288, #28772
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR is related to the following issues and PRs: #32287, #28777, #32288,
#28772.
Previous efforts related to JSON-serializing DagRun configuration have
provided an elegant solution in the form of a custom JSON encoder class named
`WebEncoder`, which is used to encode non-JSON serializable objects stored in
`DagRun.conf`. This allows DAG run conf to be correctly rendered in the grid
view, but the fix was not applied to the list view, hence breaking
`/dagrun/list` if there are conf values that are not JSON serializable.
This PR attempts to address the incompleteness of the previous fix by using
`WebEncoder` in `formatters_columns`, which should allow non-JSON-serializable
conf to be rendered in list view in the same way it is rendered in grid view.
Note that `www.utils.json_f` is used exactly once where the code change
happened, and the code change seems trivial, so I am not sure if unit tests or
other forms of validation is warranted, but I am happy to write tests if
necessary.
Thank you for considering my contribution!
---
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
