amoghrajesh opened a new pull request, #32394:
URL: https://github.com/apache/airflow/pull/32394
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Seems that pytest will walk up looking for other conftest.py files beyond
the tests/charts repo due to which the helm chart tests require DB init to be
done which should not be the case. The tests inside `tests` finds the nearest
`_clear_db` fixture and continues to use it. We should not use that conftest
fixture for helm chart tests.
So likely then https://github.com/apache/airflow/pull/28631 had side-effect
of trying to clear db where it was not initialized
This PR moves the helm charts tests outside `tests/charts` to `test-charts`.
Tested using the steps:
1. Created a new env
2. Ran the command
`pip install -e ."[devel]" --constraint
https://raw.githubusercontent.com/apache/airflow/constraints-main/constraints-source-providers-3.8.txt
`
4. Ran the tests in test-charts and we are good :+1:! Did not have to init
any DB at all
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
