potiuk commented on code in PR #32117:
URL: https://github.com/apache/airflow/pull/32117#discussion_r1254227927
##########
scripts/in_container/configure_environment.sh:
##########
@@ -23,6 +23,7 @@ readonly TMUX_CONF_FILE=".tmux.conf"
if [[ -d "${FILES_DIR}" ]]; then
export AIRFLOW__CORE__DAGS_FOLDER="/files/dags"
+ export AIRFLOW__CORE__PLUGINS_FOLDER='/files/plugins'
Review Comment:
> Or they should be in the tests directory. But code around this was
designed 7 years ago so I’m not going to waste time complaining 😉 We can
probably improve it if we want to…
Yeah. It was LOOONG before my time and I always found it cumbersome, but
never gotten to fix it.
But we've moved to pytest and actually, it could be something that we can
turn into auto-used pytest_fixtures to set the right environment for alll
tests, I believe. Before moving to pytest, this "load_test_config" thingie was
not really easy to do, but with conftest.py and fixtures, all that it does, can
I think be done there.
I think this would inflate the scope of this change quite a lot, but might
be worth it.
@utkarsharma2 - WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
