eladkal edited a comment on issue #5564: [AIRFLOW-4289] fix spark_binary argument being ignored in SparkSubmit… URL: https://github.com/apache/airflow/pull/5564#issuecomment-516411245 @ashb Isn't it already covered by `test_resolve_connection_spark_binary_set_connection` it takes `conn_id='spark_binary_set'` and verify `spark_binary` is set to `custom-spark-submit` We also have `test_resolve_connection_spark_home_not_set_connection` which verify the default of `spark_binary` is set to `spark-submit` Should I also update `UPDATING.md` ? I'm not sure if this is considered a breaking change yet we do change the default value of the contractor.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
