vincbeck opened a new pull request, #32408: URL: https://github.com/apache/airflow/pull/32408
This PR moves the FAB security manager to the FAB auth manager directory. It moves: - airflow/www/security.py -> airflow/auth/managers/fab/fab_security/airflow_manager.py - airflow/www/fab_security/manager.py -> airflow/auth/managers/fab/fab_security/base_manager.py - airflow/www/fab_security/sqla/manager.py -> airflow/auth/managers/fab/fab_security/manager.py The security manager is highly correlated to FAB, thus we want to move it to the FAB auth manager. In future PRs we want to move features which are part of the security manager to the auth manager. It will be done in separate PRs. The only concern/question I have is, users are able to override the security manager through config (see code [here](https://github.com/apache/airflow/blob/main/airflow/www/extensions/init_appbuilder.py#L677)). Therefore, when moving features from security manager to auth manager we might break experience from users who overrode the security manager. Example: my plan was to move the security manager method [register_views](https://github.com/apache/airflow/blob/main/airflow/www/fab_security/manager.py#L735) to the FAB auth manager and call the new method [here](https://github.com/apache/airflow/blob/main/airflow/www/extensions/init_appbuilder.py#L343). But if some users overrode this method in their own security manager, the experience will be broken. Any thoughts? Should I check if users overrode the security manager in the new auth manager method `register_views` and if so, execute this method? cc @potiuk <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
