amoghrajesh commented on code in PR #830:
URL: https://github.com/apache/airflow-site/pull/830#discussion_r1257814442
##########
post-docs/README.md:
##########
@@ -7,3 +7,6 @@ To generate these back referencing (refresh HTMLs), run the
script in the follow
```commandline
python add-back-reference.py [airflow | providers | helm]
```
+
+Before running the script, make sure to install requirements from
`requirements.txt` file into
+your virtual environment.
Review Comment:
Can we provide the command here?
`pip install -r requirements.txt` here?
##########
post-docs/add-back-references.py:
##########
@@ -149,9 +154,8 @@ def generate_back_references(link, base_path):
elif gen_type == GenerationType.providers:
all_providers = [f.path.split("/")[-1] for f in
os.scandir(docs_archive_path)
if f.is_dir() and "providers" in f.name]
- for p in all_providers:
- log.info("processing airflow provider: %s", p)
- generate_back_references(get_github_redirects_url(p),
get_provider_docs_path(p))
+ for provider in all_providers:
+ print(f"Processing airflow provider: {provider}")
+ generate_back_references(get_github_redirects_url(provider),
get_provider_docs_path(provider))
else:
- log.error("invalid type of doc generation required. Pass one of [airflow |
providers | "
- "helm]")
+ print("[red]Invalid type of doc generation required[/]. Pass one of
[airflow | providers | helm]")
Review Comment:
nit: `[red]Invalid type of doc generation requested[/]. Pass one of [airflow
| providers | helm]`
##########
post-docs/requirements.txt:
##########
@@ -0,0 +1 @@
+rich
Review Comment:
I think we also need to add `urllib` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
