eladkal commented on code in PR #32488:
URL: https://github.com/apache/airflow/pull/32488#discussion_r1258372092
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -810,8 +810,10 @@ class BigQueryGetDataOperator(GoogleCloudBaseOperator):
:param dataset_id: The dataset ID of the requested table. (templated)
:param table_id: The table ID of the requested table. (templated)
- :param project_id: (Optional) The name of the project where the data
- will be returned from. If None, it will be derived from the hook's
project ID. (templated)
+ :param table_project_id: (Optional) The project ID of the requested table.
+ If None, it will be derived from the hook's project ID. (templated)
+ :param project_id: (Optional) Google Cloud Project where the job is
running.
Review Comment:
You are changing what project_id means
If we want to do it can only be done in major release and even then its not
something I am comfortable with as it may cause confusion for users.
My best advise here is deprecate project_id and use 2 new explicit parameter
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
