uranusjr commented on code in PR #32351:
URL: https://github.com/apache/airflow/pull/32351#discussion_r1259262314
##########
airflow/utils/task_group.py:
##########
@@ -543,6 +554,13 @@ def iter_tasks(self) -> Iterator[AbstractOperator]:
f"Encountered a DAGNode that is not a TaskGroup or an
AbstractOperator: {type(child)}"
)
+ def add_to_taskgroup(self, task_group: TaskGroup) -> None:
+ """No-op, since we're not a task.
+
+ :meta private:
+ """
+ ...
Review Comment:
Probably needs some more text to explain why not being a task makes this a
no-op. It’s not immediately obvious why an edge modifier should not be added to
a task group.
Also the `...` is not needed.
##########
airflow/utils/task_group.py:
##########
@@ -543,6 +554,13 @@ def iter_tasks(self) -> Iterator[AbstractOperator]:
f"Encountered a DAGNode that is not a TaskGroup or an
AbstractOperator: {type(child)}"
)
+ def add_to_taskgroup(self, task_group: TaskGroup) -> None:
+ """No-op, since we're not a task.
+
+ :meta private:
+ """
+ ...
Review Comment:
Probably needs some more text to explain why not being a task makes this a
no-op. It’s not immediately obvious why an edge modifier should not be added to
a task group.
Also the `...` is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
