amoghrajesh commented on PR #32495: URL: https://github.com/apache/airflow/pull/32495#issuecomment-1630518363
> > My speculation on this task is that we send in a skeleton first and then continually improve/refactor it > > Quite the contrary, I think it will be ok to iterate until it's ready and we can use it. > > There is no big value in having a new command that cannot provide a good, usable output. And by doing that you can also learn about all the different pieces, so it makes sense to iterate and do it "right" rather than "fast". Also Breeze is integral part of the CI process and there are many pre-commits that guard the right things to be done there - for example they will make sure that any command added to breeze needs to be described what it does in BREEZE.rst, including automatically generated screenshot, so we cannot merge a "failing" PR which will skip those steps (and this is very deliberate choice). Any PR merged should contain: > > * new command > * documentation > * tests if applicable > * and provide a usable command that does something useful > * and that command should be part of CI and (in this case) release process. > > This is the "complete" implementation of a new command, which I consider as necessary for the PR to be mergable. Thanks for the point. Now, I agree with you. In this case, having a complete PR is more important than having parts and pieces going in. Working on it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
