amoghrajesh commented on PR #32495: URL: https://github.com/apache/airflow/pull/32495#issuecomment-1630848092
> As part of this change, we should also (to make it really complete) to add a step of publishing docs to this CI job: > > https://github.com/apache/airflow/blob/3f6ac2f216808cb3f227bb77ba751cb17fbd2a14/.github/workflows/ci.yml#L632 > > This way the new command will be automatically tested on CI and we will not have regressions at least as a "smoke test". This is the approach we have for pretty much all other commands in breeze - they are executed as part of the CI and this way we make sure they continue working. > > This CI job already built all the docs and we have them locally, so It should be done in few separate steps. > > * cloning the "apache/airflow-site" repo (the `AIRFLOW_SITE_DIRECTORY` environment variable should point to to the directory so that it can be used automatically by the `breeze command` > * running the three publish-docs with `--override-versioned` flag (this is because in many cases we will be overriding documentation for already relased packages. The `--package-filter` flags for the command can be taken from `${{ needs.build-info.outputs.docs-filter-list-as-string }}` which is already used in `build-docs` - those `--package-filter` strings are generated automatically during selective checks based on which files are changed in the PR, so documentation will be generated only for those packages and we can publish the generated documentation safely with those filters. Awesome idea, let us integrate the CI to do this as well. I will try this portion out too! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
