dstandish commented on code in PR #31241:
URL: https://github.com/apache/airflow/pull/31241#discussion_r1260017602
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -151,8 +151,10 @@ def __init__(
self.formatter: logging.Formatter
self.handler: logging.FileHandler | logging.StreamHandler # type:
ignore[assignment]
- def _render_log_id(self, ti: TaskInstance, try_number: int) -> str:
+ def _render_log_id(self, ti: TaskInstance | TaskInstanceKey, try_number:
int) -> str:
with create_session() as session:
Review Comment:
probably we can / should avoid creating the session if not using
USE_PER_RUN_LOG_ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
