eladkal commented on code in PR #32526: URL: https://github.com/apache/airflow/pull/32526#discussion_r1260092780
########## airflow/providers/celery/executors/__init__.py: ########## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. Review Comment: Do we need to add minimum airflow version to all files under this folder? We need to consider that users of lower Airflow versions will have newer Celery provider version and they might think that bug fixes made to the providers can be used with their executor ########## tests/sensors/test_base.py: ########## @@ -44,6 +42,8 @@ from airflow.models import TaskReschedule from airflow.models.xcom import XCom from airflow.operators.empty import EmptyOperator +from airflow.providers.celery.executors.celery_executor import CeleryExecutor +from airflow.providers.celery.executors.celery_kubernetes_executor import CeleryKubernetesExecutor Review Comment: I don't think we allow importing of providers paths in core? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
