o-nikolas opened a new pull request, #32612: URL: https://github.com/apache/airflow/pull/32612
A lot of work has been done to optimize load time of the Executor modules so that they can be included in the CLI code path (so that executors can vend cli commands, part of AIP-51, see [this PR](https://github.com/apache/airflow/pull/29055)). It has come up several times to add a test to assert the CLI runtime does not regress, while working on this code recently I found one such regression (OTEL related, not yet present in main, which I will fix in another PR) so I was motivated to add one. I played around with several options, but none captured the full extent of any delays/regressions beyond actually calling the airflow CLI in a subprocess call, which is what this unit test does. Timing related tests are often troublesome because they can be flaky if, for example, they are run on an env that is bogged down/slow they may breach their assertions. But if we give a large enough (but still reasonable) threshold, I think we'll get more benefit than harm. But I'm curious to hear what others think. CC: @potiuk # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. --- name: Pull request description: File a pull request body: - type: markdown # yamllint disable rule:line-length value: > Thank you for contributing! Please make sure that your code changes are covered with tests. In case of new features or big changes, remember to adjust the documentation. In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE Feel free to ping committers for the review! How to write a good git commit message: http://chris.beams.io/posts/git-commit/ # yamllint enable rule:line-length - type: textarea placeholder: Add meaningful description here - type: markdown # yamllint disable rule:line-length value: > Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). # yamllint enable rule:line-length -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
