brokenjacobs commented on code in PR #32608:
URL: https://github.com/apache/airflow/pull/32608#discussion_r1264414833
##########
chart/values.yaml:
##########
@@ -562,6 +562,10 @@ workers:
AND queue != '{{
.Values.config.celery_kubernetes_executor.kubernetes_queue }}'
{{- end }}
+ # Weather to use PGBouncer to connect to the database or not when it is
enabled
+ # This configuration will be ignored if PGBouncer is not enabled
+ usePgbouncer: true
Review Comment:
I agree it should be false by default, only because we don’t know how
everyone’s postgresql is configured. It is possible, although unlikely, that
connections from keda could be refused to the Postgres db due to pg_hba or
networkpolicy, and this would be a breaking change on upgrade.
##########
chart/values.yaml:
##########
@@ -562,6 +562,10 @@ workers:
AND queue != '{{
.Values.config.celery_kubernetes_executor.kubernetes_queue }}'
{{- end }}
+ # Weather to use PGBouncer to connect to the database or not when it is
enabled
+ # This configuration will be ignored if PGBouncer is not enabled
+ usePgbouncer: true
Review Comment:
I agree it should be false by default, only because we don’t know how
everyone’s postgresql is configured. It is possible, although unlikely, that
connections from keda could be refused to the Postgres db due to pg_hba or
networkpolicy, and this would be a breaking change on upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
