stelsemeyer-m60 commented on code in PR #31008:
URL: https://github.com/apache/airflow/pull/31008#discussion_r1264605936
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -595,6 +602,7 @@ def invoke_defer_method(self):
should_delete_pod=self.is_delete_operator_pod,
get_logs=self.get_logs,
startup_timeout=self.startup_timeout_seconds,
+ startup_check_interval=self.startup_check_interval_seconds,
Review Comment:
Ok, going through the code base, I came across different occurrences of
unparametrized `time.sleep` calls (with either 1 or 2 seconds):
1.
`airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.await_pod_start`:
the startup polling, set to 1s
2.
`airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.fetch_container_logs`:
polling that follows the logs, set to 1s
3.
`airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.await_container_completion`:
polling of container state if log following is deactivated, set to 1s
4.
`airflow.providers.cncf.kubernetes.utils.pod_manager.PodManager.await_pod_completion`:
same as above for container completion, set to 2s
5.
`airflow.providers.cncf.kubernetes.triggers.pod.KubernetesPodTrigger.run`: set
to 2s
I think we want to change 1 but not 2 to 4. I am not sure for 5 though,
because it does also check for the status once the pod is running, no? Please
correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
